Irgendwie Sinnlos

Marquies

Habe ein Gans simples Script geschrieben. Es soll einfach nur einen Counter hochzählen.

Code

mysql_query("UPDATE threads SET counter=counter+ 1 , ip='$REMOTE_ADDR' WHERE id ='$tid' ");

Wie man da erkennt soll das Feld counter um 1 erhöht werden. Aber trotzdem wird es immer um 2 erhöht.
Wenn ich aber dann mal ganz dumm direkt wieder -1 einbaue bleibt der counter auf dem alten Stand.

Code

mysql_query("UPDATE threads SET counter=counter+ 1 -1 , ip='$REMOTE_ADDR' WHERE id ='$tid' ");

Vielleicht könnt ihr mir ja helfen.

Marquies

Kleiner Edit: es heißt ganz^^

DER_Brain

ganz seltsam.. ich denke normalerweise funktioniert es auf diese art schon...

probiers mal so:

mysql_query("UPDATE threads SET counter=(counter+ 1) , ip='$REMOTE_ADDR' WHERE id ='$tid' ");

lg
Andi

Ich finde den fehler einfach nicht. Vielleicht habe ich ja das Script einfach nur 2 mal aufgerufen aber naja.
Guckt einfach mal den kompletten Quelltext an.

PHP

<?php
// Session wird gestartet-------------------------------------------------------------------------------------------------------//
session_start();														//
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Template und Datenbank Verbindung wird geladen-------------------------------------------------------------------------------//
include("connect.inc.php");													//
include("../template/index.inc.php");												//
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Kopf Bereich wird Ausgegeben-------------------------------------------------------------------------------------------------//
echo "$head";															//
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Header mit Menü wird ausgegeben----------------------------------------------------------------------------------------------//
echo "$body_header";														//
// Ende-------------------------------------------------------------------------------------------------------------------------//






//###############################################Scripte Anfang############################################################################################//
// User-Online Script wird geladen----------------------------------------------------------------------------------------------//
if(isset($_SESSION['user'])) {													//
																//
$sql = "select COUNT(*) as count from registered where ip = '".$_SERVER['REMOTE_ADDR']."'";					//
$result = mysql_query($sql);													//
$row = mysql_fetch_assoc($result);												//
																//
if($row['count']) {														//
																//
$sql = "update registered set date = NOW() where ip= '".$_SERVER['REMOTE_ADDR']."'";						//
        mysql_query($sql);													//
																//
}else{																//
																//
$nameonline = $_SESSION['user'];												//
$sql = "insert into registered (ip, name, date) values ('".$_SERVER['REMOTE_ADDR']."', '$nameonline', NOW())";			//
mysql_query($sql);														//
																//
}																//
																//
}else{																//
																//
$sql = "select COUNT(*) as count from online where ip = '".$_SERVER['REMOTE_ADDR']."'";						//
$result = mysql_query($sql);													//
$row = mysql_fetch_assoc($result);												//
																//
if($row['count']) {														//
																//
$sql = "update online set date = NOW() where ip= '".$_SERVER['REMOTE_ADDR']."'";						//
        mysql_query($sql);													//
																//
}else{																//
																//
$sql = "insert into online (ip, date) values ('".$_SERVER['REMOTE_ADDR']."', NOW())";						//
mysql_query($sql);														//
}																//
																//
}																//
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Counter für die Themen wird aktualisiert-------------------------------------------------------------------------------------//
$tid = $_GET['tid'];														//
																//
mysql_query("UPDATE threads SET counter=(counter+ 1) , ip='$REMOTE_ADDR' WHERE id ='$tid' ");					//
// Ende-------------------------------------------------------------------------------------------------------------------------//




// "Letzter Beitrag" für viewtopics.php-----------------------------------------------------------------------------------------//
																//
$fid = $_GET['fid'];														//
$tid = $_GET['tid'];														//
																//
$sql = mysql_query("select max(id) as mid from comments where fid = '$fid' and tid = '$tid'");					//
$row = mysql_fetch_assoc($sql);													//
																//
$mid = $row["mid"];														//
																//
$sql = mysql_query("select * from comments where id = '$mid'");									//
$row = mysql_fetch_assoc($sql);													//
																//
$lasttid = $row["tid"];														//
$lasttopic = $row["thread"];													//
$lastauthor = $row["user"];													//
$lastdate = $row["date"];													//
$lasttime = $row["time"];													//
																//
mysql_query("update lastcomment set thread = '$lasttopic',  author = '$lastauthor', date = '$lastdate', time = '$lasttime' where id = '$fid' and tid = '$tid'");
																//
																//
																//
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Anzahl der Antworten wird aktualisiert---------------------------------------------------------------------------------------//
$sql =  mysql_query("SELECT COUNT(id) AS c_id FROM comments where fid = ".$_GET["fid"]." and tid=".$_GET["tid"]);		//
$row =  mysql_fetch_assoc($sql);												//
$count2 = $row["c_id"];														//
																//
$sqlup = "update threads set answers ='$count2' - 1 where fid =".$_GET["fid"]." and id=".$_GET["tid"]."";			//
$queryup = mysql_query($sqlup);													//
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Profile werden aktualisiert--------------------------------------------------------------------------------------------------//
$name = $_SESSION['user'];													//
																//
$sql =  mysql_query("SELECT COUNT(id) AS c_id from comments where user = '$name' ");						//
$row =  mysql_fetch_assoc($sql);												//
																//
$count3 = $row["c_id"];														//
																//
$sqlup = "update users set posts ='$count3'  where user = '$name' ";								//
$queryup = mysql_query($sqlup);													//
// Ende-------------------------------------------------------------------------------------------------------------------------//
//###################################################Scripte Ende##########################################################################################//








//###################################################Beiträge Anfang#######################################################################################//
// Beiträge werden ausgegeben---------------------------------------------------------------------------------------------------//
echo " <table align=\"center\" width=\"717\" cellspacing=\"1\" cellpadding=\"5\" border=\"0\">


";
echo "<tr> 
";
echo "  <td>
";
echo "<img border=\"0\" src=\"img/line.gif\" height=\"1\" width=\"100%\">
";
echo "  </td>
";
echo "  <td>
";
echo "<span>
";
echo "<img src=\"img/line.gif\" height=\"1\" width=\"100%\">
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
echo "<tr class=\"mainmenu\">
"; 
echo "  <th width=\"150\">
";
echo "Autor
";
echo "  </th>
";
echo "  <th>
";
echo "Nachricht
";
echo "  </th>
";
echo "</tr>


";
echo "<tr> 
";
echo "  <td>
";
echo "<img src=\"img/line.gif\" height=\"1\" width=\"100%\">
";
echo "  </td>
";
echo "  <td>
";
echo "<img src=\"img/line.gif\" height=\"1\" width=\"100%\">
";
echo " </td>
";
echo "</tr>


";
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Name des Forums und des Threads wird ausgegeben------------------------------------------------------------------------------//
$sql =  mysql_query("select id, name from forum where id=".$_GET["fid"]);


while($row =  mysql_fetch_array($sql)) {


echo "<tr>
";
echo "  <td colspan=\"2\">
";
echo "<span>
";
echo "<a class=\"forumheader\" href=\"index.php\"><- ".$row["name"]."</a>
";
echo "</span>
";
}


echo "<span class=\"forumheader\">
";
echo "|
";
echo "</span>
";


$sql =  mysql_query("select * from threads where id=".$_GET["tid"]);


while($row =  mysql_fetch_array($sql)) {


echo "<span>
";
echo "<a class=\"forumheader\" href=\"viewtopics.php?fid=".$row["fid"]."\"> ".$row["topic"]."</a>
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
}
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Beiträge mit Profilen werden ausgegeben--------------------------------------------------------------------------------------//
$sql = mysql_query("SELECT comments.id AS id, comments.fid AS fid,comments.tid AS tid, comments.user AS user, comments.topic AS topic, comments.text AS text, comments.date AS date, comments.time AS time, users.date AS joindate, users.time AS jointime, users.posts AS posts, users.pic AS pic FROM comments INNER JOIN users ON comments.userid=users.id where fid=".$_GET["fid"]." and tid=".$_GET["tid"]." ORDER BY id ASC"); 




// Abfrage nach Marquies fürs Delete Script-------------------------------------------------------------------------------------//
if($_SESSION['user'] == "Marquies") {


while($row =  mysql_fetch_array($sql)) {


echo "<tr>
";
echo "  <td width=\"150\" class=\"bgcolor\">
";
echo "<span class=\"mainmenu\">
";
echo "".$row["user"]."
";
echo "</span>
";
echo "  </td>
";
echo "  <td class=\"bgcolor\">
";
echo "<span class=\"forumsdetails\">
";
echo "<img src=\"img/post.gif\">Verfasst am: 
";
echo "</span>
";
echo "<span class=\"mainmenu\">
";
echo "".$row["date"].", ".$row["time"]." 
";
echo "</span>
";
echo "<span>
";
echo "<img src=\"img/spacer.gif\" height=\"1\" width=\"50%\"><a class=\"forumsdetails\" href=\"javascript:self.scrollTo(0,50000);\">Nach unten</a>
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
echo "<tr>
";
echo "  <td  width=\"150\" class=\"comments\" valign=\"top\">
";
echo "<span>
";
echo "<img src=\"".$row["pic"]."\" width=\"80\" height=\"80\">
";
echo "</span>


";
echo "




";
echo "<span class=\"forumsdetails\">
";
echo "NICHT FERTIG


";
echo "




";
echo "




";
echo "Dabei seit:


";
echo "




";
echo "<span class=\"mainmenu\">
";
echo "".$row["joindate"]." ".$row["jointime"]."
";
echo "</span>


";
echo "




";
echo "Beiträge: 
";
echo "<span class=\"mainmenu\">
";
echo "".$row["posts"]."
";
echo "</span>


";
echo "




";
echo "




";
echo "</span>
";
echo "  </td>
";
echo "  <td class=\"comments\" valign=\"top\">
";
echo "<span class=\"forumsdetails\">
";
echo "Titel: ".$row["topic"]."


";
echo "




";
echo "<img src=\"img/line.gif\" height=\"1\" width=\"100%\">


";
echo "




";
echo "




";
echo "".nl2br($row["text"])."
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
echo "<tr>
";
echo " <td class=\"comments\">
";
echo "<span>
";
echo "<a class=\"forumsdetails\" href=\"javascript:self.scrollTo(0,1);\">Nach oben</a>
";
echo "</span>
";
echo "  </td>
";
echo "  <td class=\"comments\">
";
echo "<span class=\"rechts\">
";
echo "<a class=\"forumsdetails\" href=\"deletecomment.php?id=".$row['id']."&fid=".$row['fid']."&tid=".$row['tid']."\">Delete</a>
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
echo "<tr>
";
echo "  <td width=\"0\" height=\"18\">
";
echo "  </td>
";
echo "</tr>


";
}


}else{


while($row =  mysql_fetch_array($sql)) {




echo "<tr>
";
echo "  <td width=\"150\" class=\"bgcolor\">
";
echo "<span class=\"mainmenu\">
";
echo "".$row["user"]."
";
echo "</span>
";
echo "  </td>
";
echo "  <td class=\"bgcolor\">
";
echo "<span class=\"forumsdetails\">
";
echo "<img src=\"img/post.gif\">Verfasst am: 
";
echo "</span>
";
echo "<span class=\"mainmenu\">
";
echo "".$row["date"].", ".$row["time"]." 
";
echo "</span>
";
echo "<span>
";
echo "<img src=\"img/spacer.gif\" height=\"1\" width=\"50%\"><a class=\"forumsdetails\" href=\"javascript:self.scrollTo(0,50000);\">Nach unten</a>
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
echo "<tr>
";
echo "  <td  width=\"150\" class=\"comments\" valign=\"top\">
";
echo "<span>
";
echo "<img src=\"".$row["pic"]."\" width=\"80\" height=\"80\">
";
echo "</span>


";
echo "




";
echo "<span class=\"forumsdetails\">
";
echo "NICHT FERTIG


";
echo "




";
echo "




";
echo "Dabei seit:


";
echo "




";
echo "<span class=\"mainmenu\">
";
echo "".$row["joindate"]." ".$row["jointime"]."
";
echo "</span>


";
echo "




";
echo "Beiträge: 
";
echo "<span class=\"mainmenu\">
";
echo "".$row["posts"]."
";
echo "</span>


";
echo "




";
echo "




";
echo "</span>
";
echo "  </td>
";
echo "  <td class=\"comments\" valign=\"top\">
";
echo "<span class=\"forumsdetails\">
";
echo "Titel: ".$row["topic"]."


";
echo "




";
echo "<img src=\"img/line.gif\" height=\"1\" width=\"100%\">


";
echo "




";
echo "




";
echo "".nl2br($row["text"])."
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
echo "<tr>
";
echo " <td class=\"comments\">
";
echo "<span>
";
echo "<a class=\"forumsdetails\" href=\"javascript:self.scrollTo(0,1);\">Nach oben</a>
";
echo "</span>
";
echo "  </td>
";
echo "  <td class=\"comments\">
";
echo "  </td>
";
echo "</tr>


";
echo "<tr>
";
echo "  <td width=\"0\" height=\"18\">
";
echo "  </td>
";
echo "</tr>


";
}
}
// Ende-------------------------------------------------------------------------------------------------------------------------//




// Zeit und Buttons für neue Posts wird ausgegeben------------------------------------------------------------------------------//
echo "<tr>
";
echo "  <td colspan=\"2\" align=\"right\">
";
echo "<span class=\"forumsdetails\">
";
echo "Alle Zeiten sind GMT + 1 Stunde
";
echo "</span>
";
echo "  </td>
";
echo "</tr>


";
echo "<tr>
";
echo "  <td colspan=\"2\">
";
echo "<img src=\"img/line.gif\" width=\"100%\" height=\"1\">
";
echo "  </td>
";
echo "</tr>


";


$sql =  mysql_query("select * from threads where fid=".$_GET["fid"]." AND tid=".$_GET["tid"]); 


echo "<tr>
";
echo "  <td align=\"left\" colspan=\"2\">
";
echo "<a href=\"newtopic.php?fid=".$_GET["fid"]."\"><img border=\"0\" src=\"img/newthread.gif\"></a>
";
echo "<a href=\"newcomment.php?fid=".$_GET["fid"]."&tid=".$_GET["tid"]."\"><img border=\"0\" src=\"img/newcomment.gif\"></a>
";
echo "  </td>
";
echo "</tr>


";


echo " </table>
";
// Ende-------------------------------------------------------------------------------------------------------------------------//
//###################################################Beiträge Ende#########################################################################################//








// Hier wird der Fotter Bereich ausgegeben--------------------------------------------------------------------------------------//
echo "$body_footer";														//
// Ende-------------------------------------------------------------------------------------------------------------------------//
?>

Alles anzeigen

dereK

Vll liegt es daran, dass du einfach nur $counter++ schreiben musst.dann addiert er immer +1

also ich mach das immer so

No0ob

Manchmal hat SQL Probleme mit der direkten Erhöhung von Werten. Am besten, du liest es erstmal aus, und schreibst statt counter + eins eine PHP-Variable hin, die die neue Zahl beinhaltet

Tags